mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70683: Added helpers for evolving operation-related proto messages.
Date Wed, 22 May 2019 04:06:25 GMT


> On May 21, 2019, 12:07 p.m., Benjamin Bannier wrote:
> > src/internal/evolve.hpp
> > Lines 106-114 (original), 122-133 (patched)
> > <https://reviews.apache.org/r/70683/diff/1/?file=2145951#file2145951line122>
> >
> >     This helper doesn't seem to fit well, and we'd only use this helper in a single
spot later on in the chain.
> >     
> >     I'd suggest to remove it here and just manually adjust in the later patch.

Removed all evolve helpers and added a devolve helper instead. In the test introduced in the
later patch, all operations are generated with v1 proto messages, since operation feedback
is only supported in v1.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70683/#review215403
-----------------------------------------------------------


On May 20, 2019, 10:30 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70683/
> -----------------------------------------------------------
> 
> (Updated May 20, 2019, 10:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Greg Mann.
> 
> 
> Bugs: MESOS-9485
>     https://issues.apache.org/jira/browse/MESOS-9485
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helpers for evolving operation-related proto messages.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 1044d9df75b6fc1f60d3704be9cb5751e6d4321d 
>   src/internal/evolve.cpp 19c155967bf090fb2ec39211805ff1385787ab59 
> 
> 
> Diff: https://reviews.apache.org/r/70683/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message