mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.
Date Wed, 22 May 2019 03:03:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70621/
-----------------------------------------------------------

(Updated May 22, 2019, 3:03 a.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9395
    https://issues.apache.org/jira/browse/MESOS-9395


Repository: mesos


Description
-------

The full paths of simulated volumes are now in their ID instead of their
contextual information. This simplifies SLRP tests, and makes it cleaner
if we want to customize the contextual information in the future.


Diffs (updated)
-----

  src/examples/test_csi_plugin.cpp 03f782ead136a79c4c5b099496072933f6737598 
  src/tests/storage_local_resource_provider_tests.cpp ec2222d7aeef1cb3d1a5b4b3419dfd912d41a8c6



Diff: https://reviews.apache.org/r/70621/diff/2/

Changes: https://reviews.apache.org/r/70621/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message