mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70620: Made SLRP allow changes in volume context.
Date Wed, 22 May 2019 02:58:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70620/
-----------------------------------------------------------

(Updated May 22, 2019, 2:58 a.m.)


Review request for mesos, Benjamin Bannier and James DeFelice.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9395
    https://issues.apache.org/jira/browse/MESOS-9395


Repository: mesos


Description
-------

To make SLRP more robust against non-conforming CSI plugins that change
volume contexts, the `getExistVolumes` method returns a list of resource
conversions consisting of one for converting old volume contexts to new
volume contexts, and one to remove missing volumes and add new volumes.

To make the interfaces consistent, `getStoragePools` now also returns a
list of resource conversions consisting of one conversion.


Diffs (updated)
-----

  include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d 
  include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44 
  src/resource_provider/storage/provider.cpp 999fe95bb6f38f5a25068accd854b37788b24028 


Diff: https://reviews.apache.org/r/70620/diff/2/

Changes: https://reviews.apache.org/r/70620/diff/1-2/


Testing
-------

sudo make check
more testing done later in chain


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message