mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Review Request 70695: Renamed `*Roles` into `*RoleNames` in the allocator code.
Date Tue, 21 May 2019 17:36:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70695/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9701
    https://issues.apache.org/jira/browse/MESOS-9701


Repository: mesos


Description
-------

This patch renames variables like `set<string>& newRoles`
to keep consistency with renaming of `string role` into
`string RoleName` and to avoid confusing readers after `struct Role`
containing role-specific data is introduced.


Diffs
-----

  src/master/allocator/mesos/allocator.hpp 2d83f382eed9d9dca218adf84bc03883f7486349 
  src/master/allocator/mesos/hierarchical.cpp 6df9a3b4ef470e57862815a862494cdb5e26d3e3 


Diff: https://reviews.apache.org/r/70695/diff/1/


Testing
-------

make check


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message