mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70668: Fixed the race between validating and applying FrameworkInfo updates.
Date Tue, 21 May 2019 13:47:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70668/
-----------------------------------------------------------

(Updated May 21, 2019, 1:47 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258 and MESOS-9763
    https://issues.apache.org/jira/browse/MESOS-7258
    https://issues.apache.org/jira/browse/MESOS-9763


Repository: mesos


Description
-------

This patch moves the FrameworkInfo update validation into the
continuation of the SUBSCRIBE calls (after authorization). This fixes
the race between two concurrent SUBSCRIBE calls attempting to change
principal (see MESOS-9763) and prevents the future changes of the update
validation from exacerbating this race.


Diffs (updated)
-----

  src/master/master.cpp 24bd9572741c033c02d03a3a3a35d7d4ed8b60de 


Diff: https://reviews.apache.org/r/70668/diff/2/

Changes: https://reviews.apache.org/r/70668/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message