mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70685: Removed the `TaskStatusUpdateIsTerminalState` matcher.
Date Tue, 21 May 2019 12:41:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70685/#review215407
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On May 21, 2019, 12:34 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70685/
> -----------------------------------------------------------
> 
> (Updated May 21, 2019, 12:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `TaskStatusUpdateIsTerminalState` test matcher does not handle both
> v0 and v1 status updates. Since introducing such a matcher in the
> `v1::scheduler` namespace is inconsistent and it is not hard to use the
> built-in `Truly` matcher to implement the same functionality, this
> matcher is removed for now.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 7f5bd8cd4c07b724fe2c49068bf327e5afe9ec41

>   src/tests/mesos.hpp e70e0e1bbebef41557f9bb1f26c379357fc74e2a 
> 
> 
> Diff: https://reviews.apache.org/r/70685/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message