mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70686: Added a unit test for master operation authorization.
Date Tue, 21 May 2019 12:07:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70686/#review215405
-----------------------------------------------------------


Fix it, then Ship it!




This is a very exhaustive test, but slightly hard to follow.


src/tests/master_authorization_tests.cpp
Lines 3317-3320 (patched)
<https://reviews.apache.org/r/70686/#comment302092>

    If you get rid of the `vector` `evolve` function in r/70683/ we'd create a temporary `RepeatedPtrField`
and convert when creating the accept call.
    
    ````
    RepeatedPtrField<v1::Offer::Operation> operations_ =
      evolve<v1::Offer::Operation, Offer::Operation>(
          {operations.begin(), operations.end()});
          
    mesos.send(v1::createCallAccept(
        subscribed->framework_id(),
        offers->offers(0),
        {operations_.begin(), operations_.end()}));
    ````



src/tests/mesos.hpp
Line 1818 (original), 1860 (patched)
<https://reviews.apache.org/r/70686/#comment302089>

    Unintentional edit?


- Benjamin Bannier


On May 21, 2019, 12:37 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70686/
> -----------------------------------------------------------
> 
> (Updated May 21, 2019, 12:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9485
>     https://issues.apache.org/jira/browse/MESOS-9485
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that allowing or denying an action will only result
> in a success or failure on specific operations but not other operations
> in an accept call. This is a regression test for MESOS-9474 and
> MESOS-9480.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp c740bf7c4af1699dd71a31f9169d29c1b4adb40d 
>   src/tests/master_authorization_tests.cpp f65b6210a8189ec5e9089bce845a46d325253058 
>   src/tests/mesos.hpp e70e0e1bbebef41557f9bb1f26c379357fc74e2a 
>   src/tests/mock_slave.hpp 326a450eb2ae9912a19c6e0220e80f74d2953add 
>   src/tests/mock_slave.cpp 1122c2a8b56b9d4e5deea4e892d81061f5e39a8d 
> 
> 
> Diff: https://reviews.apache.org/r/70686/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Ran the unit test under stress for 500 iterations.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message