mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70679: Fixed comment to reflect the existence of sorters other than DRF.
Date Tue, 21 May 2019 09:32:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70679/#review215401
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp
Line 1862 (original), 1862 (patched)
<https://reviews.apache.org/r/70679/#comment302087>

    I find the newline here hurts readability a bit, I will remove it when I make the push.


- Meng Zhu


On May 20, 2019, 9:26 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70679/
> -----------------------------------------------------------
> 
> (Updated May 20, 2019, 9:26 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed comment to reflect the existence of sorters other than DRF.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 6df9a3b4ef470e57862815a862494cdb5e26d3e3

> 
> 
> Diff: https://reviews.apache.org/r/70679/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message