mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70620: Made SLRP allow changes in volume context.
Date Mon, 20 May 2019 22:52:14 GMT


> On May 12, 2019, 12:44 a.m., James DeFelice wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 1078 (patched)
> > <https://reviews.apache.org/r/70620/diff/1/?file=2144328#file2144328line1087>
> >
> >     how often are these conversions applied? i suppose it's every time that reconciliation
happens - how often is that?

Right now it only happens once when the SLRP is restarted. The plan is to make this happen
periodically or on demand through https://issues.apache.org/jira/browse/MESOS-9254.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70620/#review215202
-----------------------------------------------------------


On May 10, 2019, 1:14 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70620/
> -----------------------------------------------------------
> 
> (Updated May 10, 2019, 1:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and James DeFelice.
> 
> 
> Bugs: MESOS-9395
>     https://issues.apache.org/jira/browse/MESOS-9395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To make SLRP more robust against non-conforming CSI plugins that change
> volume contexts, the `getExistVolumes` method returns a list of resource
> conversions consisting of one for converting old volume contexts to new
> volume contexts, and one to remove missing volumes and add new volumes.
> 
> To make the interfaces consistent, `getStoragePools` now also returns a
> list of resource conversions consisting of one conversion.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto dc6a87f14864cb4d46b9856f251c2946a475162d 
>   include/mesos/v1/mesos.proto e8086e0f70cac73876a8ae31db3365b5059b5c44 
>   src/resource_provider/storage/provider.cpp 999fe95bb6f38f5a25068accd854b37788b24028

> 
> 
> Diff: https://reviews.apache.org/r/70620/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> more testing done later in chain
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message