mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70684: Changed the `*TaskIdEq` test matchers to take a `TaskID`.
Date Mon, 20 May 2019 22:32:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70684/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Greg Mann.


Bugs: MESOS-9485
    https://issues.apache.org/jira/browse/MESOS-9485


Repository: mesos


Description
-------

The `TaskStatusTaskIdEq` and `TaskStatusUpdateTaskIdEq` matchers
previously take a `TaskInfo`, which is not very intuitive and
inconsistent with other matchers such as `OptionTaskHasTaskID`. By
making these matchers take a `TaskID` we also reduce coupling of this
matcher and the structure of `TaskInfo`.


Diffs
-----

  src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 7f5bd8cd4c07b724fe2c49068bf327e5afe9ec41

  src/tests/default_executor_tests.cpp 93d7a1cfa1a9df838426c8257b6158e3553b5037 
  src/tests/gc_tests.cpp a583f1d79a9dd9def24ccfeb9e49ea0392173420 
  src/tests/master_tests.cpp 964d935771a99efaee63187affe46b551146f310 
  src/tests/mesos.hpp e70e0e1bbebef41557f9bb1f26c379357fc74e2a 
  src/tests/partition_tests.cpp 8148aff6bf1d9637d486b549d7f8c7124566d86c 
  src/tests/slave_tests.cpp 50882a5aa1b20c234f3cec8366f346fa9bfd4f83 


Diff: https://reviews.apache.org/r/70684/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message