mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70667: Added unit tests for 'framework::validateUpdate()'.
Date Mon, 20 May 2019 19:17:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70667/#review215377
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_validation_tests.cpp
Lines 4773-4774 (patched)
<https://reviews.apache.org/r/70667/#comment302059>

    Usually when the wrapping is this far, we'll wrap on the next line:
    
    ```
        EXPECT_NONE(framework::validateUpdate(
            DEFAULT_FRAMEWORK_INFO, frameworkInfo));
            
        // or:
            
        EXPECT_NONE(framework::validateUpdate(
            DEFAULT_FRAMEWORK_INFO,
            frameworkInfo));
    ```



src/tests/master_validation_tests.cpp
Lines 4785 (patched)
<https://reviews.apache.org/r/70667/#comment302061>

    Ditto on the previous patch, this should be a TODO that https://reviews.apache.org/r/70669/
later removes, to make it clear to the reader what the plan is.


- Benjamin Mahler


On May 17, 2019, 3:06 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70667/
> -----------------------------------------------------------
> 
> (Updated May 17, 2019, 3:06 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit tests for 'framework::validateUpdate()'.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 1b7a8273f2704e0a4dedf33c55ede33dc1b1a4af 
> 
> 
> Diff: https://reviews.apache.org/r/70667/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message