mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70665: Moved the logic of sending 'Framework' updates into a separate method.
Date Mon, 20 May 2019 18:19:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70665/#review215374
-----------------------------------------------------------




src/master/master.hpp
Lines 667 (patched)
<https://reviews.apache.org/r/70665/#comment302051>

    Why did this need to be passed separately? Is there some reason `framework->pid` can't
be used?



src/master/master.cpp
Lines 2819 (patched)
<https://reviews.apache.org/r/70665/#comment302050>

    newline



src/master/master.cpp
Lines 2832-2835 (original), 2839-2842 (patched)
<https://reviews.apache.org/r/70665/#comment302048>

    This looks like a bug, the pid needs to be set here in the non http api case.



src/master/master.cpp
Lines 3151 (patched)
<https://reviews.apache.org/r/70665/#comment302049>

    newline


- Benjamin Mahler


On May 17, 2019, 3:03 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70665/
> -----------------------------------------------------------
> 
> (Updated May 17, 2019, 3:03 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch consolidates the scattered logic of sending Framework updates
> (namely, the FRAMEWORK_ADDED event to master V1 API subscribers and
> UpdateFrameworkMessage to agents).
> 
> NOTE: The UpdateFrameworkMessage is now also being sent in the case of
> non-`forced` subscription request from a framework which has already
> been registered. Previously it was not being sent in this case -
> this likely is a bug.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp c523c937e294eaffe0e58306c267770c119c9f42 
>   src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d 
> 
> 
> Diff: https://reviews.apache.org/r/70665/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message