mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70626: Refactored `untrackReservations()` method.
Date Mon, 20 May 2019 11:03:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70626/#review215352
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for the refactoring!


src/master/allocator/mesos/hierarchical.cpp
Line 2642 (original), 2642 (patched)
<https://reviews.apache.org/r/70626/#comment302011>

    `untrackRole` or just `untrack`?


- Meng Zhu


On May 16, 2019, 7:16 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70626/
> -----------------------------------------------------------
> 
> (Updated May 16, 2019, 7:16 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9701
>     https://issues.apache.org/jira/browse/MESOS-9701
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch gets rid of insertion into the beginning of the vector
> and also of shadowing HierarchicalAllocatorProcess::roles by a local.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 875cfcd091f5f58afb89e752da5100a75828dd67

> 
> 
> Diff: https://reviews.apache.org/r/70626/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message