mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.
Date Thu, 09 May 2019 22:12:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/#review215171
-----------------------------------------------------------


Fix it, then Ship it!




Looks like the description didn't run through the git commit hooks?

```
$ ./support/apply-reviews.py -r 70531
2019-05-09 17:58:38 URL:https://reviews.apache.org/r/70531/diff/raw/ [2632/2632] -> "70531.patch"
[1]
Checking 2 C++ files
Done processing src/master/master.cpp
Done processing src/master/master.hpp
Error: No line in the commit message summary may exceed 72 characters.
```


src/master/master.hpp
Lines 1148 (patched)
<https://reviews.apache.org/r/70531/#comment301708>

    paren on the previous line


- Benjamin Mahler


On May 7, 2019, 11:15 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70531/
> -----------------------------------------------------------
> 
> (Updated May 7, 2019, 11:15 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch replaces the `Call:Subscribe` message in the arguments of            
> `Master::validateFrameworkSubscription()` with its constituents:                
> the `FrameworkInfo` and the list of suppressed roles.                             
>                                                                                 
> The motivation behind this change is to help keep the new UPDATE_FRAMEWORK call 
> (being introduced in MESOS-7258) consistent with re-subscribing the framework   
> by using the same `Master::validateFrameworkSubscription()` method to validate  
> both SUBSCRIBE and UPDATE_FRAMEWORK calls.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
>   src/master/master.cpp a8ee6297e1587c160a47b806914d3c3aa4f35cd7 
> 
> 
> Diff: https://reviews.apache.org/r/70531/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message