mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.
Date Mon, 06 May 2019 23:00:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70549/
-----------------------------------------------------------

(Updated May 6, 2019, 4 p.m.)


Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Changes
-------

Clarified why a new action is introduced.


Bugs: MESOS-9640
    https://issues.apache.org/jira/browse/MESOS-9640


Repository: mesos


Description (updated)
-------

A new authorizable action `update_quota_configs` is added.
This disambiguates with the old action `update_quota`
which are used for the old `SetQuota` and
`RemoveQuota` calls. `update_quota` action requires
`QuotaInfo` as the object while the new `UpdatedQuota` call
uses `QuotaConfig`. To keep it compatible with any external
authorization modules, a new action `update_quota_config`
is introduced.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.proto e2740c402732bb37db991ec92b9301e58b33215b 
  src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
  src/master/quota_handler.cpp 5d449e6f027a69ccaa0ac3473ea4cf57441601f3 


Diff: https://reviews.apache.org/r/70549/diff/2/

Changes: https://reviews.apache.org/r/70549/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message