mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70598: Added blogpost for 1.8.0 release.
Date Mon, 06 May 2019 17:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70598/#review215065
-----------------------------------------------------------


Fix it, then Ship it!




Thanks Benno!

Showing stats seems interesting, maybe just things like JIRA ticket count, # of commits, #
lines added / deleted, as opposed to which files and folders?


site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 13-14 (patched)
<https://reviews.apache.org/r/70598/#comment301449>

    number of commits as well?



site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 14 (patched)
<https://reviews.apache.org/r/70598/#comment301448>

    the period here will lead people to interpret it as 60 rather than 60000 (in american
english at least..), you could use "k" or nothing?



site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 16-49 (patched)
<https://reviews.apache.org/r/70598/#comment301447>

    These snippets should probably be in triple backtick sections to ensure they are monospaced
and lined up when rendered?



site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 38-49 (patched)
<https://reviews.apache.org/r/70598/#comment301450>

    is this lines of code? commits touching the files? something else?
    
    the subfolder stuff seems a bit bizarre here, for example, is the number for src/ `src
- src subfolders shown above`?
    
    Perhaps a hierarchically displayed version will be less prone to confusion?
    
    ```
        30.2% src/
              11.0% src/master
               7.8% src/cli
        4.0% support/
               3.7% support/python3/
    
    ```
    
    But then 11% here isn't clear if it's 11% of src's 30% or 11% of the overall changes.
    
    I don't have any good suggestions, but I think the summary stats are interesting. Curious
how other projects display them..



site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 54 (patched)
<https://reviews.apache.org/r/70598/#comment301452>

    newline?



site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 59 (patched)
<https://reviews.apache.org/r/70598/#comment301451>

    s/F/f/ or should probably just say scheduler to stay consistent with the rest of this
section and to be clear that it's the scheduler part of the framework



site/source/blog/2019-05-02-mesos-1-8-0-released.md
Lines 141 (patched)
<https://reviews.apache.org/r/70598/#comment301453>

    extra newline here?


- Benjamin Mahler


On May 6, 2019, 2:47 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70598/
> -----------------------------------------------------------
> 
> (Updated May 6, 2019, 2:47 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added blogpost for 1.8.0 release.
> 
> 
> Diffs
> -----
> 
>   site/source/blog/2019-05-02-mesos-1-8-0-released.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70598/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message