mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70587: Fixed unguarded calls to `Option::get()` in the master.
Date Sat, 04 May 2019 17:49:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70587/#review215051
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70587]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On May 2, 2019, 10 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70587/
> -----------------------------------------------------------
> 
> (Updated May 2, 2019, 10 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9698
>     https://issues.apache.org/jira/browse/MESOS-9698
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch avoids making unguarded calls to `Option<FrameworkID>::get()`
> in `Master::updateOperationStatus()`. During agent reregistration, it's
> possible that a `ReregisterSlaveMessage` from the agent can race with a
> `SlaveReregisteredMessage` from the master, leading to multiple rounds
> of master/agent operation reconciliation. The duplicate operation status
> updates which occur as a result would crash the master before this fix.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 7dcdc9ab62a46638a027eb9a54c1dff173785927 
>   src/tests/agent_operation_feedback_tests.cpp e427441b3ef702acf0fba52adf7ba027ea6bc508

> 
> 
> Diff: https://reviews.apache.org/r/70587/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*DroppedOperationDuplicateStatusUpdate*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message