mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70595: Adds a regression test for MESOS-9766.
Date Fri, 03 May 2019 23:31:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70595/#review215035
-----------------------------------------------------------




3rdparty/libprocess/src/tests/process_tests.cpp
Lines 2086 (patched)
<https://reviews.apache.org/r/70595/#comment301415>

    Should `/__processes__` be quoted by backticks? Ditto below.



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 2090 (patched)
<https://reviews.apache.org/r/70595/#comment301422>

    How about `NoProcessesEndpointHang`?



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 2092-2108 (patched)
<https://reviews.apache.org/r/70595/#comment301419>

    I tried this unit test w/o the fix in the following settings:
    1. `--gtest_repeat=100`, which resulted in 3 passes and 97 failures.
    2. Invoked the test w/o repetition in a for-loop, which resulted in 60 passes and 40 failures.
    
    So it seems to me that this test passes fairly easily if it only runs once.
    
    Then I replace this snippet with the following code, which just used 1 actor but failed
every time in the above two settings:
    ```
      UPID pid = spawn(new ProcessBase(), true);
    
      dispatch(pid, [] { os::sleep(Milliseconds(50)); });
    
      http::URL url = http::URL(
          "http",
          process::address().ip,
          process::address().port,
          "/__processes__");
    
      Future<http::Response> response = http::get(url);
    
      terminate(pid, true);
    ```



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 2110-2112 (patched)
<https://reviews.apache.org/r/70595/#comment301417>

    `AWAIT_EXPECT_RESPONSE_STATUS_EQ(http::OK().status, response);`


- Chun-Hung Hsiao


On May 3, 2019, 7:58 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70595/
> -----------------------------------------------------------
> 
> (Updated May 3, 2019, 7:58 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9766
>     https://issues.apache.org/jira/browse/MESOS-9766
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test fails on master prior to applying the fix for MESOS-9766.
> It attempts to ensure that processes are terminated after the
> /__processes__ handler dispatches to them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 60f3dd653153c2b2ccf9c3a7eae8c75fd6ff025c

> 
> 
> Diff: https://reviews.apache.org/r/70595/diff/1/
> 
> 
> Testing
> -------
> 
> Ran in repetition, although it appears to consistently fail on master without repetition
needed.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message