mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.
Date Thu, 02 May 2019 22:44:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69954/
-----------------------------------------------------------

(Updated May 2, 2019, 10:44 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed Benjamin's comment.


Bugs: MESOS-9565
    https://issues.apache.org/jira/browse/MESOS-9565


Repository: mesos


Description
-------

Test `CreateDestroyPersistentBlockVolume` verifies that SLRP would fail
a `CREATE` operation on a BLOCK disk resource, and a followup `DESTROY`
will be dropped (instead of failing the SLRP).


Diffs (updated)
-----

  src/tests/mock_csi_plugin.cpp cbcb59f720642c2801f5b86c438793e24437b414 
  src/tests/storage_local_resource_provider_tests.cpp 8bf4d2331b59770a7b7f3768499047bec2d67677



Diff: https://reviews.apache.org/r/69954/diff/4/

Changes: https://reviews.apache.org/r/69954/diff/3-4/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message