mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.
Date Thu, 02 May 2019 22:42:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/
-----------------------------------------------------------

(Updated May 2, 2019, 10:42 p.m.)


Review request for mesos, Benjamin Bannier and Jan Schlicht.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9627
    https://issues.apache.org/jira/browse/MESOS-9627


Repository: mesos


Description
-------

This patch enables the unit test to test against CSI v1 through the
following changes:

  * The forwarding mode of the test CSI plugin now respects the
    `--api_version` option. When specified, only requests of the proper
    CSI version will be forwarded.

  * The expectations of `CreateVolume` and `DeleteVolume` calls in the
    unit tests are parameterized against the CSI version string.

  * The mock CSI plugin now provides a default implementation for the
    `GetCapacity` call so the unit test can be simplified.


Diffs (updated)
-----

  src/examples/test_csi_plugin.cpp b54d666a878576f5845027fe6f704e10195079e1 
  src/tests/mock_csi_plugin.cpp cbcb59f720642c2801f5b86c438793e24437b414 
  src/tests/storage_local_resource_provider_tests.cpp 8bf4d2331b59770a7b7f3768499047bec2d67677



Diff: https://reviews.apache.org/r/70431/diff/2/

Changes: https://reviews.apache.org/r/70431/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message