mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 70587: Fixed unguarded calls to `Option::get()` in the master.
Date Thu, 02 May 2019 22:00:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70587/
-----------------------------------------------------------

Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Till Toenshoff.


Bugs: MESOS-9698
    https://issues.apache.org/jira/browse/MESOS-9698


Repository: mesos


Description
-------

This patch avoids making unguarded calls to `Option<FrameworkID>::get()`
in `Master::updateOperationStatus()`. During agent reregistration, it's
possible that a `ReregisterSlaveMessage` from the agent can race with a
`SlaveReregisteredMessage` from the master, leading to multiple rounds
of master/agent operation reconciliation. The duplicate operation status
updates which occur as a result would crash the master before this fix.


Diffs
-----

  src/master/master.cpp 7dcdc9ab62a46638a027eb9a54c1dff173785927 
  src/tests/agent_operation_feedback_tests.cpp e427441b3ef702acf0fba52adf7ba027ea6bc508 


Diff: https://reviews.apache.org/r/70587/diff/1/


Testing
-------

`make check`
`bin/mesos-tests.sh --gtest_filter="*DroppedOperationDuplicateStatusUpdate*" --gtest_repeat=-1
--gtest_break_on_failure`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message