mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70534: Added tests for UPDATE_FRAMEWORK.
Date Thu, 02 May 2019 16:06:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70534/
-----------------------------------------------------------

(Updated May 2, 2019, 4:06 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Added tests for updates sent by the master to slaves and API subscribers.


Summary (updated)
-----------------

Added tests for UPDATE_FRAMEWORK.


Bugs: MESOS-7258
    https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
-------

This patch adds tests for the UPDATE_FRAMEWORK call.

The reason behind implementing the MasterAPISubscriber class with mock methods is the need
to wait for interesting API events while skipping uninteresting ones. 
This is needed to properly test the FRAMEWORK_UPDATED event sent by the master (for that I
need to wait for AGENT_ADDED and FRAMEWORK_UPDATED, and to skip everything else).

I'm in doubts about the proper location for the MasterAPISubscriber. On one hand, it is used
only by these tests and the implementation is by no means complete; on the other hand, this
might be useful in other tests of the master API behaviour. 
Probably, turning the MasterAPISubscriber into a general-purpose mock (and moving it into
another file at that point) should be a separate task.


Diffs (updated)
-----

  src/Makefile.am 5f97523fbe2d80733fbdcc7706f2761f5a071f9f 
  src/tests/CMakeLists.txt e6b1d8a097246f0921467d7f778034d6754fcff6 
  src/tests/update_framework_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70534/diff/3/

Changes: https://reviews.apache.org/r/70534/diff/2-3/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message