mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70570: Logged headroom related info in the allocator.
Date Wed, 01 May 2019 19:23:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review214982
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp
Lines 1798-1799 (patched)
<https://reviews.apache.org/r/70570/#comment301265>

    Can we also say what needs to be held back?
    
    Hm.. I wonder if we should this information log before and after the allocation cycle
completes?


- Benjamin Mahler


On April 30, 2019, 1 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
> 
> (Updated April 30, 2019, 1 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9759
>     https://issues.apache.org/jira/browse/MESOS-9759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Logged headroom related info in the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87

> 
> 
> Diff: https://reviews.apache.org/r/70570/diff/2/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message