mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] lava commented on issue #335: Return early in fetcher if no uris are specified.
Date Thu, 23 May 2019 16:03:17 GMT
lava commented on issue #335: Return early in fetcher if no uris are specified.
URL: https://github.com/apache/mesos/pull/335#issuecomment-495281497
 
 
   Hey @carlonelong , 
   
   thanks for contributing!
   
   Your patch looks reasonable to me, however when I ran it through our CI it seemed to break
a few unit tests, in particular:
   
   Test Name | Duration | Age
   -- | -- | --
   mesos-ec2-ubuntu-16.04-SSL.Mesos.DockerContainerizerTest.ROOT_DOCKER_UNPRIVILEGED_USER_NonRootSandbox
| 6 sec | 1
   mesos-ec2-ubuntu-16.04-SSL.Mesos.MesosContainerizerExecuteTest.ROOT_UNPRIVILEGED_USER_SandboxFileOwnership
| 0.1 sec | 1
   mesos-ec2-ubuntu-16.04-SSL.Mesos.MesosContainerizerDestroyTest.DestroyWhileFetching | 15
sec | 1
   mesos-ec2-ubuntu-16.04-SSL.Mesos.ProvisionerDockerTest.ROOT_INTER
   
   (and the same for debian9, centos6/7, ubuntu 14.04, etc.)
   
   I did not have the time to investigate what exactly is causing these tests to fail, but
I think this will need to be investigated before we can commit the patch.
   
   Best regards,
   Benno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message