From reviews-return-87300-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 23 07:23:49 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 584D719728 for ; Tue, 23 Apr 2019 07:23:49 +0000 (UTC) Received: (qmail 32865 invoked by uid 500); 23 Apr 2019 07:23:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 32839 invoked by uid 500); 23 Apr 2019 07:23:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 32807 invoked by uid 99); 23 Apr 2019 07:23:47 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Apr 2019 07:23:47 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 990EEE0F50; Tue, 23 Apr 2019 07:23:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 86FBEC4022A; Tue, 23 Apr 2019 07:23:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7382486658531238644==" MIME-Version: 1.0 Subject: Re: Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework. From: Mesos Reviewbot Windows To: Chun-Hung Hsiao , Meng Zhu Cc: Mesos Reviewbot Windows , Benjamin Mahler , mesos Date: Tue, 23 Apr 2019 07:23:46 -0000 Message-ID: <20190423072346.11160.31946@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70508/ X-Sender: Mesos Reviewbot Windows References: <20190422164726.38492.18926@reviews-vm2.apache.org> In-Reply-To: <20190422164726.38492.18926@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============7382486658531238644== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70508/#review214809 ----------------------------------------------------------- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['70132', '70508']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3238/mesos-review-70508 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3238/mesos-review-70508/logs/mesos-tests.log): ``` I0423 07:23:27.538352 70628 master.cpp:3333] Disconnecting agent 4fd80e2a-3f22-4bb3-a43f-c9b747d99501-S0 at slave(501)@192.10.1.4:63077 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0423 07:23:27.539352 70628 master.cpp:3352] Deactivating agent 4fd80e2a-3f22-4bb3-a43f-c9b747d99501-S0 at slave(501)@192.10.1.4:63077 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) I0423 07:23:27.539352 70164 hierarchical.cpp:392] Removed framework 4fd80e2a-3f22-4bb3-a43f-c9b747d99501-0000 I0423 07:23:27.539352 70164 hierarchical.cpp:829] Agent 4fd80e2a-3f22-4bb3-a43f-c9b747d99501-S0 deactivated I0423 07:23:27.539352 74600 containerizer.cpp:2576] Destroying container da45affc-a0d6-4ba1-835c-8f74d50d29b0 in RUNNING state I0423 07:23:27.539352 74600 containerizer.cpp:3278] Transitioning the state of container da45affc-a0d6-4ba1-835c-8f74d50d29b0 from RUNNING to DESTROYING I0423 07:23:27.539352 74600 launcher.cpp:[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (683 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (701 ms total) [----------] Global test environment tear-down [==========] 1162 tests from 109 test cases ran. (595934 ms total) [ PASSED ] 1159 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage [ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName 3 FAILED TESTS YOU HAVE 233 DISABLED TESTS 161] Asked to destroy container da45affc-a0d6-4ba1-835c-8f74d50d29b0 W0423 07:23:27.541344 74432 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=6068 to peer '192.10.1.4:65468': IO failed with error code: The specified network name is no longer available. W0423 07:23:27.542357 74432 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=4144 to peer '192.10.1.4:65469': IO failed with error code: The specified network name is no longer available. I0423 07:23:27.548353 73712 containerizer.cpp:3117] Container da45affc-a0d6-4ba1-835c-8f74d50d29b0 has exited I0423 07:23:27.577365 59656 master.cpp:1135] Master terminating I0423 07:23:27.578368 63304 hierarchical.cpp:680] Removed agent 4fd80e2a-3f22-4bb3-a43f-c9b747d99501-S0 I0423 07:23:28.626175 74432 process.cpp:927] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On April 22, 2019, 4:47 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70508/ > ----------------------------------------------------------- > > (Updated April 22, 2019, 4:47 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Meng Zhu. > > > Bugs: MESOS-5804 > https://issues.apache.org/jira/browse/MESOS-5804 > > > Repository: mesos > > > Description > ------- > > The test failed in MESOS-5804 due to the following race: > > 1. Framework launches task T, moves from RESERVED to > TASK_RUNNING state. > 2. Allocation cycle triggers and will send the unreserved > resources to the framework. > 3. Before the offer gets to the framework, task T finishes and > framework moves from TASK_RUNNING to RESERVED. > 4. In the RESERVED state, the framework expects the reservation > in the offer. But, it's coming in a later offer, and the one > that arrives is for the unreserved resources since it was > generated while the task was still running. > > Tne fix applied here for this specific race is to use a 2 week > filter rather than a 0 second filter. That would ensure that the > unreserved resources do not get re-offered to the framework on > their own. However, this fix does not work until MESOS-9616 is > resolved. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp f9c7dfe46a1e8dd1bc8eae45ed1b65b7a6d60dfc > > > Diff: https://reviews.apache.org/r/70508/diff/1/ > > > Testing > ------- > > Test passes with https://reviews.apache.org/r/70132/ applied. > > > Thanks, > > Benjamin Mahler > > --===============7382486658531238644==--