From reviews-return-87136-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 11 15:11:58 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 6C35819A6A for ; Thu, 11 Apr 2019 15:11:58 +0000 (UTC) Received: (qmail 58325 invoked by uid 500); 11 Apr 2019 15:11:57 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 58309 invoked by uid 500); 11 Apr 2019 15:11:57 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 58292 invoked by uid 99); 11 Apr 2019 15:11:57 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Apr 2019 15:11:57 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0873BE015A; Thu, 11 Apr 2019 15:11:57 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E8F57C4025D; Thu, 11 Apr 2019 15:11:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0677124261053297898==" MIME-Version: 1.0 Subject: Re: Review Request 70454: Fixed potential use-after-free bug in storage local resource provider. From: Mesos Reviewbot To: Chun-Hung Hsiao Cc: Benjamin Bannier , Mesos Reviewbot , mesos Date: Thu, 11 Apr 2019 15:11:56 -0000 Message-ID: <20190411151156.62691.41374@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70454/ X-Sender: Mesos Reviewbot References: <20190411125515.62691.79859@reviews-vm2.apache.org> In-Reply-To: <20190411125515.62691.79859@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============0677124261053297898== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70454/#review214585 ----------------------------------------------------------- Patch looks great! Reviews applied: [70454] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 11, 2019, 12:55 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70454/ > ----------------------------------------------------------- > > (Updated April 11, 2019, 12:55 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9711 > https://issues.apache.org/jira/browse/MESOS-9711 > > > Repository: mesos > > > Description > ------- > > The storage local resource provider manages a metrics instance which is > shared with the service and volume managers it also holds; these > services do not manage the lifetime of the metrics instance. > > This patch fixes the lifetime of the metrics instance. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp b2ca5d0735cbd11b8a9689359e05d6bd723b8a64 > > > Diff: https://reviews.apache.org/r/70454/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > > --===============0677124261053297898==--