| Benjamin Mahler |
Re: Review Request 70346: Removed unused function `Resources::isScalarQuantity`. |
Mon, 01 Apr, 15:39 |
| Benjamin Mahler |
Re: Review Request 70345: Simplified quota chopping logic in the allocator. |
Mon, 01 Apr, 18:45 |
| Benjamin Mahler |
Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate. |
Mon, 01 Apr, 18:46 |
| Meng Zhu |
Re: Review Request 70345: Simplified quota chopping logic in the allocator. |
Mon, 01 Apr, 19:37 |
| Benjamin Mahler |
Re: Review Request 70345: Simplified quota chopping logic in the allocator. |
Mon, 01 Apr, 19:39 |
| Benjamin Mahler |
Review Request 70352: Added roles::ancestors for walking up the role hierarchy. |
Mon, 01 Apr, 23:57 |
| Benjamin Mahler |
Review Request 70353: Fixed quota enforcement in the presence of subrole reservations. |
Mon, 01 Apr, 23:57 |
| Meng Zhu |
Re: Review Request 70353: Fixed quota enforcement in the presence of subrole reservations. |
Tue, 02 Apr, 00:31 |
| Meng Zhu |
Re: Review Request 70352: Added roles::ancestors for walking up the role hierarchy. |
Tue, 02 Apr, 00:37 |
| Meng Zhu |
Re: Review Request 70353: Fixed quota enforcement in the presence of subrole reservations. |
Tue, 02 Apr, 00:47 |
| Gastón Kleiman |
Re: Review Request 70335: Sent FrameworkInfo to agents when applying operations. |
Tue, 02 Apr, 00:50 |
| Gilbert Song |
Review Request 70354: Refactored the UCR docker store to construct 'Image' proto at pullers. |
Tue, 02 Apr, 01:21 |
| Jie Yu |
Review Request 70355: Switched to used `/proc/1/ns/pid` to test pid namespaces. |
Tue, 02 Apr, 01:25 |
| Jie Yu |
Review Request 70356: Mounted /proc properly a container shares pid namespace with its parent. |
Tue, 02 Apr, 01:26 |
| Mesos Reviewbot |
Re: Review Request 70353: Fixed quota enforcement in the presence of subrole reservations. |
Tue, 02 Apr, 02:00 |
| Qian Zhang |
Re: Review Request 70354: Refactored the UCR docker store to construct 'Image' proto at pullers. |
Tue, 02 Apr, 03:21 |
| James Peach |
Re: Review Request 70355: Switched to used `/proc/1/ns/pid` to test pid namespaces. |
Tue, 02 Apr, 03:49 |
| Mesos Reviewbot |
Re: Review Request 70354: Refactored the UCR docker store to construct 'Image' proto at pullers. |
Tue, 02 Apr, 04:10 |
| Chun-Hung Hsiao |
Re: Review Request 70168: Refactored SLRP with `ServiceManager` to manage container lifecycles. |
Tue, 02 Apr, 05:26 |
| Chun-Hung Hsiao |
Re: Review Request 70213: Added the `VolumeManager` interface to manage CSI volumes. |
Tue, 02 Apr, 05:29 |
| Mesos Reviewbot Windows |
Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface. |
Tue, 02 Apr, 05:53 |
| Chun-Hung Hsiao |
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions. |
Tue, 02 Apr, 05:54 |
| Chun-Hung Hsiao |
Re: Review Request 70302: Adjusted CSI v0 bundling and proto compilation. |
Tue, 02 Apr, 06:11 |
| Chun-Hung Hsiao |
Re: Review Request 70303: Moved CSI v0 type helpers to the `mesos/csi/v0.hpp` header. |
Tue, 02 Apr, 06:12 |
| Chun-Hung Hsiao |
Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface. |
Tue, 02 Apr, 06:13 |
| Chun-Hung Hsiao |
Review Request 70360: Bundled CSI spec 1.1.0. |
Tue, 02 Apr, 06:15 |
| Chun-Hung Hsiao |
Review Request 70362: Added the `mesos::csi::v1::Client` wrapper. |
Tue, 02 Apr, 06:20 |
| Chun-Hung Hsiao |
Review Request 70361: Added spec inclusion header and type helpers for CSI v1. |
Tue, 02 Apr, 06:20 |
| Mesos Reviewbot |
Re: Review Request 70356: Mounted /proc properly a container shares pid namespace with its parent. |
Tue, 02 Apr, 06:22 |
| Chun-Hung Hsiao |
Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper. |
Tue, 02 Apr, 06:22 |
| Mesos Reviewbot |
Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper. |
Tue, 02 Apr, 07:14 |
| Mesos Reviewbot Windows |
Re: Review Request 70354: Refactored the UCR docker store to construct 'Image' proto at pullers. |
Tue, 02 Apr, 07:29 |
| Mesos Reviewbot Windows |
Re: Review Request 70353: Fixed quota enforcement in the presence of subrole reservations. |
Tue, 02 Apr, 07:35 |
| Gilbert Song |
Review Request 70365: Added protobuf for docker v2 schema2 config path in 'Image'. |
Tue, 02 Apr, 08:04 |
| Gilbert Song |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Tue, 02 Apr, 08:05 |
| Gilbert Song |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Tue, 02 Apr, 08:05 |
| Gilbert Song |
Re: Review Request 70287: Added 'prettyjws' option to docker manifest V2 Schema1 accept header. |
Tue, 02 Apr, 08:10 |
| Gilbert Song |
Re: Review Request 70354: Refactored the UCR docker store to construct 'Image' proto at pullers. |
Tue, 02 Apr, 08:10 |
| Gilbert Song |
Re: Review Request 70365: Added protobuf for docker v2 schema2 config path in 'Image'. |
Tue, 02 Apr, 08:10 |
| Gilbert Song |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Tue, 02 Apr, 08:11 |
| Gilbert Song |
Re: Review Request 70289: Added a TODO for additional URLs support. |
Tue, 02 Apr, 08:11 |
| Gilbert Song |
Re: Review Request 70290: Fixed docker fetcher plugin unit test for v2s2 change. |
Tue, 02 Apr, 08:11 |
| Gilbert Song |
Re: Review Request 70291: Added gcr registry test. |
Tue, 02 Apr, 08:11 |
| Gilbert Song |
Review Request 70366: Added a unit test for Mesos containerizer image force pulling. |
Tue, 02 Apr, 08:12 |
| Benjamin Bannier |
Review Request 70367: Added test helper to create reconcile messages. |
Tue, 02 Apr, 08:35 |
| Benjamin Bannier |
Review Request 70368: Initialized resource provider manager earlier when recovering. |
Tue, 02 Apr, 08:35 |
| James DeFelice |
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`. |
Tue, 02 Apr, 10:52 |
| Mesos Reviewbot Windows |
Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper. |
Tue, 02 Apr, 10:56 |
| Benjamin Bannier |
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`. |
Tue, 02 Apr, 11:00 |
| James DeFelice |
Re: Review Request 70247: Added an "unversioned" `VolumeCapability`. |
Tue, 02 Apr, 11:30 |
| James DeFelice |
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`. |
Tue, 02 Apr, 11:32 |
| Mesos Reviewbot Windows |
Re: Review Request 70366: Added a unit test for Mesos containerizer image force pulling. |
Tue, 02 Apr, 11:55 |
| Andrei Budnik |
Review Request 70369: Fixed compile error with a built-in logrotate module. |
Tue, 02 Apr, 11:56 |
| Mesos Reviewbot Windows |
Re: Review Request 70356: Mounted /proc properly a container shares pid namespace with its parent. |
Tue, 02 Apr, 12:43 |
| Mesos Reviewbot |
Re: Review Request 70369: Fixed compile error with a built-in logrotate module. |
Tue, 02 Apr, 13:00 |
| Qian Zhang |
Re: Review Request 70365: Added protobuf for docker v2 schema2 config path in 'Image'. |
Tue, 02 Apr, 13:17 |
| Qian Zhang |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Tue, 02 Apr, 13:18 |
| Benjamin Bannier |
Re: Review Request 70302: Adjusted CSI v0 bundling and proto compilation. |
Tue, 02 Apr, 13:50 |
| Qian Zhang |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Tue, 02 Apr, 14:13 |
| Benjamin Bannier |
Re: Review Request 70360: Bundled CSI spec 1.1.0. |
Tue, 02 Apr, 14:34 |
| Benjamin Bannier |
Re: Review Request 70361: Added spec inclusion header and type helpers for CSI v1. |
Tue, 02 Apr, 14:57 |
| Mesos Reviewbot Windows |
Re: Review Request 70368: Initialized resource provider manager earlier when recovering. |
Tue, 02 Apr, 17:40 |
| James DeFelice |
Re: Review Request 70295: Enabled launcher sealing for RPM packages. |
Tue, 02 Apr, 17:46 |
| James DeFelice |
Re: Review Request 70295: Enabled launcher sealing for RPM packages. |
Tue, 02 Apr, 17:50 |
| Benjamin Mahler |
Review Request 70370: Updated the sorters to track the root node allocation. |
Tue, 02 Apr, 19:13 |
| Meng Zhu |
Re: Review Request 70369: Fixed compile error with a built-in logrotate module. |
Tue, 02 Apr, 20:50 |
| Mesos Reviewbot |
Re: Review Request 70370: Updated the sorters to track the root node allocation. |
Tue, 02 Apr, 21:06 |
| Meng Zhu |
Re: Review Request 70370: Updated the sorters to track the root node allocation. |
Tue, 02 Apr, 21:22 |
| Chun-Hung Hsiao |
Re: Review Request 70302: Adjusted CSI v0 bundling and proto compilation. |
Tue, 02 Apr, 22:00 |
| Chun-Hung Hsiao |
Re: Review Request 70302: Adjusted CSI v0 bundling and proto compilation. |
Tue, 02 Apr, 22:02 |
| Greg Mann |
Re: Review Request 70335: Sent FrameworkInfo to agents when applying operations. |
Tue, 02 Apr, 22:09 |
| Meng Zhu |
Review Request 70371: Added a test to ensure subroles reservations are tracked correctly. |
Tue, 02 Apr, 22:29 |
| Chun-Hung Hsiao |
Re: Review Request 70247: Added an "unversioned" `VolumeCapability`. |
Tue, 02 Apr, 22:38 |
| Mesos Reviewbot Windows |
Re: Review Request 70370: Updated the sorters to track the root node allocation. |
Tue, 02 Apr, 22:42 |
| Benjamin Mahler |
Re: Review Request 70371: Added a test to ensure subroles reservations are tracked correctly. |
Tue, 02 Apr, 23:58 |
| Chun-Hung Hsiao |
Re: Review Request 70216: Cleanup the recovery logic for refactoring SLRP. |
Wed, 03 Apr, 00:00 |
| Mesos Reviewbot |
Re: Review Request 70371: Added a test to ensure subroles reservations are tracked correctly. |
Wed, 03 Apr, 00:41 |
| Chun-Hung Hsiao |
Re: Review Request 70302: Adjusted CSI v0 bundling and proto compilation. |
Wed, 03 Apr, 00:48 |
| Chun-Hung Hsiao |
Re: Review Request 70303: Moved CSI v0 type helpers to the `mesos/csi/v0.hpp` header. |
Wed, 03 Apr, 00:50 |
| Benjamin Mahler |
Review Request 70373: Added an root node overload for Sorter::allocationScalarQuantities. |
Wed, 03 Apr, 00:54 |
| Benjamin Mahler |
Review Request 70374: Added tests for Sorter::allocationScalarQuantities. |
Wed, 03 Apr, 00:54 |
| Chun-Hung Hsiao |
Re: Review Request 70360: Bundled CSI spec 1.1.0. |
Wed, 03 Apr, 00:56 |
| Chun-Hung Hsiao |
Re: Review Request 70361: Added spec inclusion header and type helpers for CSI v1. |
Wed, 03 Apr, 00:57 |
| Gilbert Song |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Wed, 03 Apr, 01:08 |
| Qian Zhang |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Wed, 03 Apr, 01:28 |
| Mesos Reviewbot |
Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper. |
Wed, 03 Apr, 01:30 |
| Chun-Hung Hsiao |
Re: Review Request 70247: Added an "unversioned" `VolumeCapability`. |
Wed, 03 Apr, 02:41 |
| Chun-Hung Hsiao |
Re: Review Request 70367: Added test helper to create reconcile messages. |
Wed, 03 Apr, 02:45 |
| Meng Zhu |
Re: Review Request 70373: Added an root node overload for Sorter::allocationScalarQuantities. |
Wed, 03 Apr, 03:08 |
| Mesos Reviewbot Windows |
Re: Review Request 70374: Added tests for Sorter::allocationScalarQuantities. |
Wed, 03 Apr, 03:09 |
| Meng Zhu |
Re: Review Request 70374: Added tests for Sorter::allocationScalarQuantities. |
Wed, 03 Apr, 03:24 |
| Mesos Reviewbot Windows |
Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper. |
Wed, 03 Apr, 03:42 |
| Qian Zhang |
Re: Review Request 70288: Supported docker manifest v2 schema2. |
Wed, 03 Apr, 03:53 |
| Qian Zhang |
Re: Review Request 70366: Added a unit test for Mesos containerizer image force pulling. |
Wed, 03 Apr, 03:56 |
| Mesos Reviewbot Windows |
Re: Review Request 70369: Fixed compile error with a built-in logrotate module. |
Wed, 03 Apr, 04:17 |
| James Peach |
Re: Review Request 70356: Mounted /proc properly a container shares pid namespace with its parent. |
Wed, 03 Apr, 04:41 |
| Chun-Hung Hsiao |
Re: Review Request 70368: Initialized resource provider manager earlier when recovering. |
Wed, 03 Apr, 05:01 |
| Mesos Reviewbot Windows |
Re: Review Request 70371: Added a test to ensure subroles reservations are tracked correctly. |
Wed, 03 Apr, 05:19 |
| Chun-Hung Hsiao |
Re: Review Request 70369: Fixed compile error with a built-in logrotate module. |
Wed, 03 Apr, 05:24 |
| Mesos Reviewbot |
Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper. |
Wed, 03 Apr, 05:39 |