mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.
Date Thu, 25 Apr 2019 19:53:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70531/
-----------------------------------------------------------

(Updated April 25, 2019, 7:53 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
    https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description (updated)
-------

To keep the UPDATE_FRAMEWORK call consistent with re-subscription we need to be able to use
the code in `Master::validateFrameworkSubscription()` to validate not only the `Call:Subscribe`
but also the `Call::UpdateFramework` submessage. 

Thus I'm making this method to take the `FrameworkInfo` and the list of suppressed roles as
arguments (instead of `Call::subscribe`).


Diffs (updated)
-----

  src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
  src/master/master.cpp 7dcdc9ab62a46638a027eb9a54c1dff173785927 


Diff: https://reviews.apache.org/r/70531/diff/2/

Changes: https://reviews.apache.org/r/70531/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message