mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70530: Added a function for validation of a FrameworkInfo update.
Date Thu, 25 Apr 2019 19:39:16 GMT


> On April 24, 2019, 7:25 p.m., Benjamin Mahler wrote:
> > src/master/master.hpp
> > Lines 2418-2423 (patched)
> > <https://reviews.apache.org/r/70530/diff/1/?file=2140824#file2140824line2418>
> >
> >     Does this need to be a member function? Is it possible to pull it up into the
stateless validation header so that we can unit test it? E.g. pass in old vs new framework
info into the function rather than rely on the master's Framework struct state

Moved it into validation.hpp, the unit tests will follow.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70530/#review214862
-----------------------------------------------------------


On April 25, 2019, 7:39 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70530/
> -----------------------------------------------------------
> 
> (Updated April 25, 2019, 7:39 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a function for validation of a FrameworkInfo update.
> 
> 
> Diffs
> -----
> 
>   src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b 
>   src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 
>   src/master/master.cpp 7dcdc9ab62a46638a027eb9a54c1dff173785927 
>   src/master/master_.cpp PRE-CREATION 
>   src/master/validation.hpp 95638a17052ece6c957aa76e4cead8d7bfe82024 
>   src/master/validation.cpp d7f210fc1ed228113c7f97bce9a43916840b2252 
> 
> 
> Diff: https://reviews.apache.org/r/70530/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message