mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 70538: WIP: Fixed upgrade path for tasks with invalid protobuf unions.
Date Wed, 24 Apr 2019 03:28:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70538/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko, Benno Evers, and Greg Mann.


Repository: mesos


Description
-------

As part of MESOS-6874, the master now validates protobuf unions
passed as part of an ExecutorInfo::ContainerInfo.  This prevents a
task from specifying, for example, a ContainerInfo::MESOS, but filling
out the `docker` field (which is then ignored by the agent).

However, if a task was already launched with an invalid protobuf
union, the same validation will happen when the agent tries to
reregister with the master.  In this case, if the master is upgraded
to validate protobuf unions, the agent reregistration will be rejected.

This adds a hack to wipe invalid fields from the agent's reregistration
message before sending it to the master.


Diffs
-----

  src/slave/slave.cpp 95f05a18c7905d5032de1cd35726ac3a17f0b682 


Diff: https://reviews.apache.org/r/70538/diff/1/


Testing
-------

WIP!!!


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message