mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70519: Transitioned tasks when an unreachable agent is marked as gone.
Date Wed, 24 Apr 2019 02:27:05 GMT


> On April 23, 2019, 4:57 p.m., Benno Evers wrote:
> > src/master/master.cpp
> > Lines 9230 (patched)
> > <https://reviews.apache.org/r/70519/diff/1/?file=2140631#file2140631line9230>
> >
> >     Nit: I'd probably write this as
> >     
> >         CHECK(slaves.recovered.contains(slaveId) || slaves.unreachable.contains(slaveId))
> >         
> >     That way the code matches exactly what's written in the comment.

Done.


> On April 23, 2019, 4:57 p.m., Benno Evers wrote:
> > src/master/master.cpp
> > Lines 9243 (patched)
> > <https://reviews.apache.org/r/70519/diff/1/?file=2140631#file2140631line9243>
> >
> >     Nit: We could save one level of indentation (and more importantly one item on
the reader's mental stack) by writing this as
> >     
> >         if (framework == nullptr) {
> >           continue;
> >         }

Done.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70519/#review214817
-----------------------------------------------------------


On April 24, 2019, 12:52 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70519/
> -----------------------------------------------------------
> 
> (Updated April 24, 2019, 12:52 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-9545
>     https://issues.apache.org/jira/browse/MESOS-9545
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the master code responsible for marking
> agents as gone to properly transition tasks on agents which
> were previously marked as unreachable.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310 
>   src/master/master.hpp e8f77d5b107a43945124a9ea00d07562a5a09450 
>   src/master/master.cpp 73a88a2720be3900e6c6575d9ac535ceec52dc12 
>   src/tests/api_tests.cpp e76417a9098281265b3411c18767bfcc2f624b6f 
> 
> 
> Diff: https://reviews.apache.org/r/70519/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*UnreachableAgentMarkedGone*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message