mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70535: Extended 'ResourceQuantities' to facilitate a bug fix.
Date Tue, 23 Apr 2019 23:44:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70535/#review214835
-----------------------------------------------------------



Bad review!

Reviews applied: [70535]

Error:
2019-04-23 23:44:41 URL:https://reviews.apache.org/r/70535/diff/raw/ [3439/3439] -> "70535.patch"
[1]
error: patch failed: src/common/resource_quantities.hpp:110
error: src/common/resource_quantities.hpp: patch does not apply

- Mesos Reviewbot


On April 23, 2019, 11:21 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70535/
> -----------------------------------------------------------
> 
> (Updated April 23, 2019, 11:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9619
>     https://issues.apache.org/jira/browse/MESOS-9619
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes minimal updates to the `ResourceQuantities`
> class in order to facilitate the fix for MESOS-9619.
> 
> The original review which added the methods included in this
> patch can be found at https://reviews.apache.org/r/70062/.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd 
>   src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f 
> 
> 
> Diff: https://reviews.apache.org/r/70535/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` after the patches associated with MESOS-9619 had been cherry-picked onto
the '1.7.x' branch.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message