mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call.
Date Tue, 23 Apr 2019 19:06:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70533/
-----------------------------------------------------------

(Updated April 23, 2019, 7:06 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
    https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
-------

Implemented UPDATE_FRAMEWORK scheduler call.

This call allows to perform the same changes in FrameworkInfo as resubscribing a framework.

HTTP return codes specific to this call:
200 OK on success
400 Bad request when the requested update is not valid.
403 Unathorized when the framework would not be authorized to use some entities (currently
roles) after the requested update.
409 Conflict when the framework is removed by a concurrent call.

No "incomplete updates" occur when an update is invalid. I.e. the update either succeeds or
fails completely.

An attempt to change framework's user/checkpointing ability is not swallowed silently, but
is treated as an error - this is different from attempting to change these properties by resubscribing
a framework.


Diffs
-----

  src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 35a04a3d0183697f93dadb3cbfead3ee0c2fea08

  src/master/http.cpp e7a92d0f554ba4cafaee5a75f09b46eb1bf4a310 
  src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7 
  src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 
  src/master/validation.cpp f032a781608857d0c9cfa220dd8d70f74d60f1ec 


Diff: https://reviews.apache.org/r/70533/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message