mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.
Date Fri, 19 Apr 2019 07:57:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70472/
-----------------------------------------------------------

(Updated April 19, 2019, 7:57 a.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Meng Zhu.


Bugs: MESOS-9619
    https://issues.apache.org/jira/browse/MESOS-9619


Repository: mesos


Description (updated)
-------

This patch adds validation to the master to ensure that task
groups do not include resources with overlapping set- or
range-valued resources, as this can crash the allocator.


Diffs
-----

  src/master/validation.hpp 71748c121aa3518d68811ea1e60707d195b58657 
  src/master/validation.cpp f032a781608857d0c9cfa220dd8d70f74d60f1ec 
  src/tests/master_tests.cpp 964d935771a99efaee63187affe46b551146f310 
  src/tests/master_validation_tests.cpp 400ad686291e08f578f27cfb9341263972e36684 


Diff: https://reviews.apache.org/r/70472/diff/2/


Testing
-------

`make check`
`bin/mesos-tests.sh --gtest_filter="*NonoverlappingSetsAndRanges*" --gtest_repeat=-1 --gtest_break_on_failure`
`bin/mesos-tests.sh --gtest_filter="*LaunchGroupOverlappingSetAndRangeResources*" --gtest_repeat=-1
--gtest_break_on_failure`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message