mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.
Date Tue, 16 Apr 2019 12:30:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/#review214688
-----------------------------------------------------------


Fix it, then Ship it!





src/examples/test_csi_plugin.cpp
Lines 1855-1857 (patched)
<https://reviews.apache.org/r/70431/#comment300894>

    Let's add documenting the expected method names here.



src/tests/storage_local_resource_provider_tests.cpp
Lines 374 (patched)
<https://reviews.apache.org/r/70431/#comment300895>

    Let's add some log output here, e.g.,
    ```
    FAIL() << "Unsupported CSI API version " << GetParam();
    ```



src/tests/storage_local_resource_provider_tests.cpp
Lines 414 (patched)
<https://reviews.apache.org/r/70431/#comment300896>

    Ditto.


- Benjamin Bannier


On April 9, 2019, 8:09 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70431/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 8:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9627
>     https://issues.apache.org/jira/browse/MESOS-9627
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables the unit test to test against CSI v1 through the
> following changes:
> 
>   * The forwarding mode of the test CSI plugin now respects the
>     `--api_version` option. When specified, only requests of the proper
>     CSI version will be forwarded.
> 
>   * The expectations of `CreateVolume` and `DeleteVolume` calls in the
>     unit tests are parameterized against the CSI version string.
> 
>   * The mock CSI plugin now provides a default implementation for the
>     `GetCapacity` call so the unit test can be simplified.
> 
> 
> Diffs
> -----
> 
>   src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
>   src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
>   src/tests/storage_local_resource_provider_tests.cpp da8db41b867d04b4236ad3515811fc00318c619c

> 
> 
> Diff: https://reviews.apache.org/r/70431/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message