mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.
Date Mon, 15 Apr 2019 22:06:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70472/#review214672
-----------------------------------------------------------




src/master/validation.cpp
Lines 902-942 (patched)
<https://reviews.apache.org/r/70472/#comment300872>

    A simpler check might be:
    
    -Add them all together
    -Subtract them all from the total, if the total reaches 0 prior to subtracting all, it
means there were some duplicate set or range items
    
    Should be pretty clean, and we should be able to give a good message since we know that
everything that still needs to be subtracted are the duplicates?



src/master/validation.cpp
Lines 1625-1629 (original), 1669-1676 (patched)
<https://reviews.apache.org/r/70472/#comment300869>

    Hm.. have we validated prior to here that the resources are valid? e.g. if the task or
executor on its own specifies overlapping ranges or sets is that allowed?


- Benjamin Mahler


On April 13, 2019, 2:04 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70472/
> -----------------------------------------------------------
> 
> (Updated April 13, 2019, 2:04 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Meng Zhu.
> 
> 
> Bugs: MESOS-9619
>     https://issues.apache.org/jira/browse/MESOS-9619
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds validation to the master to ensure that task
> groups do not include resources with overlapping set- or
> range-valued resources, as this can crash the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp 71748c121aa3518d68811ea1e60707d195b58657 
>   src/master/validation.cpp f032a781608857d0c9cfa220dd8d70f74d60f1ec 
>   src/tests/master_tests.cpp 964d935771a99efaee63187affe46b551146f310 
>   src/tests/master_validation_tests.cpp 400ad686291e08f578f27cfb9341263972e36684 
> 
> 
> Diff: https://reviews.apache.org/r/70472/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*NonoverlappingSetsAndRanges*" --gtest_repeat=-1
--gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*LaunchGroupOverlappingSetAndRangeResources*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message