mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 70477: Fixed container daemon to only wait on submitted containers.
Date Mon, 15 Apr 2019 15:27:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70477/
-----------------------------------------------------------

Review request for mesos and Chun-Hung Hsiao.


Bugs: MESOS-8428
    https://issues.apache.org/jira/browse/MESOS-8428


Repository: mesos


Description
-------

In test scenarios it is possible that we launch a container and then try
to wait for it after the agent became unavailable (unlikely outside of
tests as the lifetime of the container daemon is constrained by
lifetime of the agent). In such cases we could then fail to interact
with the agent HTTP API successfully producing transport-level errors.
In such cases we don't ever want to wait for containers.

Fixed the container daemon to take this into account. In addition to
fixing test issues this should also make the container daemon more
robust outside of tests.


Diffs
-----

  src/slave/container_daemon.cpp e1b0812b8b467ee4061b23d39552e2417d65a14a 


Diff: https://reviews.apache.org/r/70477/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message