mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 70469: Optimized weighted shuffling in the random sorter.
Date Sat, 13 Apr 2019 02:22:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70469/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9723
    https://issues.apache.org/jira/browse/MESOS-9723


Repository: mesos


Description
-------

This patch optimizes the permutation step of the weighted
shuffling function used by the random sorter.
The permutation step now has constant memory cost and
O(n) time complexity.

This is based on the algorithm described in:
https://s.apache.org/o7K0

Also added a unit test.


Diffs
-----

  src/master/allocator/sorter/random/utils.hpp 1329359040082ed128d8dbc45381aa3e529224e4 
  src/tests/sorter_tests.cpp 9d52a80eafb6f955386a6575875daacf5d4b4e9e 


Diff: https://reviews.apache.org/r/70469/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message