mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 70408: Deduplicated common validation code in Master::subscribe()'s.
Date Fri, 12 Apr 2019 21:46:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70408/#review214639
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Line 2553 (original), 2553 (patched)
<https://reviews.apache.org/r/70408/#comment300825>

    Nit: We normally only prefix underscores in method names when adding continuations of
async methods.
    
    I would call this method `validateFrameworkSubscription`.



src/master/master.cpp
Line 2620 (original), 2600 (patched)
<https://reviews.apache.org/r/70408/#comment300826>

    Please shift this line left to fix the indentation.


- Gastón Kleiman


On April 10, 2019, 8:29 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70408/
> -----------------------------------------------------------
> 
> (Updated April 10, 2019, 8:29 a.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-2842
>     https://issues.apache.org/jira/browse/MESOS-2842
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Deduplicated common validation code in Master::subscribe()'s.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7 
>   src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 
> 
> 
> Diff: https://reviews.apache.org/r/70408/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message