mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70438: Added a test of hierarchical sorting for the random sorter.
Date Fri, 12 Apr 2019 17:12:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70438/#review214636
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for the adding the test!


src/tests/sorter_tests.cpp
Lines 106-112 (patched)
<https://reviews.apache.org/r/70438/#comment300815>

    Looks like the backslash here causes multi-line comment compiling errors. Let' use block
comments 
    
    `/* */`



src/tests/sorter_tests.cpp
Lines 164-166 (patched)
<https://reviews.apache.org/r/70438/#comment300816>

    As mentioned earlier, we probably want to print out the whole table here?


- Meng Zhu


On April 9, 2019, 2:16 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70438/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 2:16 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9710
>     https://issues.apache.org/jira/browse/MESOS-9710
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test of hierarchical sorting for the random sorter.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp 9d52a80eafb6f955386a6575875daacf5d4b4e9e 
> 
> 
> Diff: https://reviews.apache.org/r/70438/diff/1/
> 
> 
> Testing
> -------
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message