-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70454/#review214587
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On April 11, 2019, 12:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70454/
> -----------------------------------------------------------
>
> (Updated April 11, 2019, 12:55 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9711
> https://issues.apache.org/jira/browse/MESOS-9711
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The storage local resource provider manages a metrics instance which is
> shared with the service and volume managers it also holds; these
> services do not manage the lifetime of the metrics instance.
>
> This patch fixes the lifetime of the metrics instance.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp b2ca5d0735cbd11b8a9689359e05d6bd723b8a64
>
>
> Diff: https://reviews.apache.org/r/70454/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|