mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70449: Avoid publishing resources when an HTTP executor resubscribes.
Date Thu, 11 Apr 2019 05:10:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70449/#review214566
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70449]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On April 11, 2019, 1:30 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70449/
> -----------------------------------------------------------
> 
> (Updated April 11, 2019, 1:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-9711
>     https://issues.apache.org/jira/browse/MESOS-9711
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After an agent failover, an HTTP executor may resubscribe before any
> resource provider resubscribes. If that happens and the executor
> has tasks consuming resources from an unsubscribed resource provider,
> the agent will fail to publish the resources and kill the executor,
> which is an undesired behavior. The patch fixes this issue.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 794a9c986b266b4916f6fbada670142798245bd1 
>   src/tests/slave_tests.cpp b1c3a01031b917fb9773c8c890a8f88838870559 
> 
> 
> Diff: https://reviews.apache.org/r/70449/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message