mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70378: Wrapped access to hashmaps in `frameworks.principals` and `authorized`.
Date Wed, 10 Apr 2019 22:01:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70378/#review214548
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70408', '70377', '70378']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3145/mesos-review-70378

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3145/mesos-review-70378/logs/mesos-tests.log):

```
    @   00007FF74A946119  lambda::internal::Partial<<lambda_603bd5fdcd93c401bd3d79eb77dc8136>,mesos::FrameworkID,process::Time,std::_Ph<1>
>::invoke_expand<<lambda_603bd5fdcd93c401bd3d79eb77dc8136>,std::tuple<mesos::FrameworkID,process::Time,std::_Ph<1>
>,std::tuple<process::Proc
    @   00007FF74A84FEFA  )<process::ProcessBase *
    @   00007FF74A87CDDC  std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_603bd5fdcd93c401bd3d79eb77dc8136>,mesos::FrameworkID,process::Time,std::_Ph<1>
>,process::ProcessBase *>
    @   00007FF74A93BF7C  std::invoke<lambda::internal::Partial<<lambda_603bd5fdcd93c401bd3d79eb77dc8136>,mesos::FrameworkID,process::Time,std::_Ph<1>
>,process::ProcessBase *>
    @   00007FF74A8565C1  )<lambda::internal::Partial<<lambda_603bd5fdcd93c401bd3d79eb77dc8136>,mesos::FrameworkID,process::Time,std::_Ph<1>
>,process::ProcessBase *
    @   00007FF74AA10EC6  process::ProcessBase *)>::CallableFn<lambda::internal::Partial<<lambda_603bd5fdcd93c401bd3d79eb77dc8136>,mesos::FrameworkID,process::Time,std::_Ph<1>
> >::operator(
    @   00007FF74CA81A6D  process::ProcessBase *)>::operator(
    @   00007FF74C93D849  process::ProcessBase::consume
    @   00007FF74CADD38A  process::DispatchEvent::consume
    @   00007FF7486F2637  process::ProcessBase::serve
    @   00007FF74C94B490  process::ProcessManager::resume
    @   00007FF74CA6F8D1   ?? 
    @   00007FF74C999B30  std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7>
>
    @   00007FF74C9F70F0  std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
    @   00007FF74C9AC76C  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Execute<0>
    @   00007FF74CAC32BA  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Run
    @   00007FF74CAAE8A8  std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
>,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7>
> > > >::_Go
    @   00007FF74CA9438D  std::_Pad::_Call_func
    @   00007FFE85FE4FB8  _register_onexit_function
    @   00007FFE85FE4BF1  _register_onexit_function
    @   00007FFE9CD33034  BaseThreadInitThunk
    @   00007FFE9ECD1471  RtlUserThreadStart
.cpp:12225] Removing offer c02b1262-0862-4db0-a81e-0284a603379b-O1
I0410 22:00:20.775607 40968 master.cpp:3219] Disconnecting framework c02b1262-0862-4db0-a81e-0284a603379b-0000
(default) at scheduler-163c0f61-6773-4a7b-97ae-83f06c55ac14@192.10.1.4:64788
I0410 22:00:20.776569 40968 master.cpp:1425] Giving framework c02b1262-0862-4db0-a81e-0284a603379b-0000
(default) at scheduler-163c0f61-6773-4a7b-97ae-83f06c55ac14@192.10.1.4:64788 0ns to failover
I0410 22:00:20.776569 40968 master.cpp:9745] Framework failover timeout, removing framework
c02b1262-0862-4db0-a81e-0284a603379b-0000 (default) at scheduler-163c0f61-6773-4a7b-97ae-83f06c55ac14@192.10.1.4:64788
I0410 22:00:20.776569 40968 master.cpp:10739] Removing framework c02b1262-0862-4db0-a81e-0284a603379b-0000
(default) at scheduler-163c0f61-6773-4a7b-97ae-83f06c55ac14@192.10.1.4:64788
F0410 22:00:20.777575 40968 master.cpp:10910] Check failed: metrics->frameworks.contains(principal.get())

I0410 22:00:20.778597 50168 slave.cpp:912] Agent terminating
```

- Mesos Reviewbot Windows


On April 3, 2019, 4:01 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70378/
> -----------------------------------------------------------
> 
> (Updated April 3, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-2842
>     https://issues.apache.org/jira/browse/MESOS-2842
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> !! This code is completely disposable and possibly not properly located; the next patch
actually does not depend on this one.
> 
> ------
> 
> After having a look at the Master code, I realized that the hashmaps `frameworks.principlas`
and `authorized` should satisfy the following property: the value corresponding to a given
key never changes.
> 
> Currently, this invariant is enforced MANUALLY with hacks of three kinds. 
> The first hack is constructs like this:
> 
> CHECK(!h.contains(key));
> h[key] = newValue;
> 
> The second hack is much worse: it is avoiding calling non-const `hashmap::operator[]()`
for nonexisting keys.
> 
> And the third one is even worse: it is avoiding this situation:
> h.erase(key);
> h[key] = newValue;
> 
> To make sure that at least the first two hacks has been used properly, I added this wrapper
around hashmap.
> Actually, this is a dirty hack itself, and not a proper decomposition of the God Object
antipattern that, IMO, has somehow started to grow inside of the Master.
> 
> Unfortunately, there is no such simple way to validate that the third kind of hacks is
used properly. (In fact, it is not - and this is the direct cause of MESOS-2842.)
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7 
>   src/master/master.cpp cf5caa0893ba1387a1f3a9d129ecd7d974f776bd 
> 
> 
> Diff: https://reviews.apache.org/r/70378/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message