mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.
Date Tue, 09 Apr 2019 23:47:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70412/#review214509
-----------------------------------------------------------


Fix it, then Ship it!




LGTM, just a couple nits below.


src/examples/operation_feedback_framework.cpp
Lines 106 (patched)
<https://reviews.apache.org/r/70412/#comment300715>

    s/RESERVATIONS_LABEL/RESERVATIONS_LABEL_KEY/



src/examples/operation_feedback_framework.cpp
Lines 326-327 (patched)
<https://reviews.apache.org/r/70412/#comment300714>

    Let's leave a comment here that we don't set an operation ID for these unreservations,
so we don't expect to receive any operation status updates for them.



src/examples/operation_feedback_framework.cpp
Lines 738 (patched)
<https://reviews.apache.org/r/70412/#comment300716>

    s/reservationsLabel/reservationsLabelValue/



src/examples/operation_feedback_framework.cpp
Lines 792 (patched)
<https://reviews.apache.org/r/70412/#comment300717>

    s/instances/instance/


- Greg Mann


On April 9, 2019, 11:39 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70412/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 11:39 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a flag to the operation feedback example framework that
> makes it unreserve resources that were reserved by another instance of
> the framework.
> 
> NOTE: The new flag should only be enabled if the example framework is
> the only framework making reservations for a given role. Otherwise it
> will unreserve reservations made by another framework.
> 
> 
> Diffs
> -----
> 
>   src/examples/operation_feedback_framework.cpp 2480c340c4ccb4246098c35e0315093f3eb44e81

> 
> 
> Diff: https://reviews.apache.org/r/70412/diff/2/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message