mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70427: Fixed a container ID generation issue in the CSI service manager.
Date Tue, 09 Apr 2019 09:04:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70427/#review214491
-----------------------------------------------------------


Fix it, then Ship it!





src/csi/service_manager.cpp
Lines 110 (patched)
<https://reviews.apache.org/r/70427/#comment300701>

    Let's throw a `reserve` call in here for good measure.
    
    ```
    services.reserve(container.services_size());
    ```


- Benjamin Bannier


On April 8, 2019, 10:59 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70427/
> -----------------------------------------------------------
> 
> (Updated April 8, 2019, 10:59 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9632
>     https://issues.apache.org/jira/browse/MESOS-9632
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a container ID generation issue in the CSI service manager.
> 
> 
> Diffs
> -----
> 
>   src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0 
> 
> 
> Diff: https://reviews.apache.org/r/70427/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message