mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70430: Avoided some recalculation in the random sorter.
Date Tue, 09 Apr 2019 08:24:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70430/#review214489
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70429', '70430']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3123/mesos-review-70430

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3123/mesos-review-70430/logs/mesos-tests.log):

```
I0409 08:24:11.416843 41404 master.cpp:1295] Agent bec6eae5-5255-4922-908b-615934fac20f-S0
at slave(500)@192.10.1.4:62080 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
disconnected
I0409 08:24:11.416843 41404 master.cpp:3333] Disconnecting agent bec6eae5-5255-4922-908b-615934fac20f-S0
at slave(500)@192.10.1.4:62080 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0409 08:24:11.416843 41404 master.cpp:3352] Deactivating agent bec6eae5-5255-4922-908b-615934fac20f-S0
at slave(500)@192.10.1.4:62080 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0409 08:24:11.417857 43052 hierarchical.cpp:392] Removed framework bec6eae5-5255-4922-908b-615934fac20f-0000
I0409 08:24:11.417857 43052 hierarchical.cpp:829] Agent bec6eae5-5255-4922-908b-615934fac20f-S0
deactivated
I0409 08:24:11.418853 39300 containerizer.cpp:2576] Destroying container 6e5cddf0-5326-41dd-b978-af6d74c53a13
in RUNNING state
I0409 08:24:11.418853 39300 containerizer.cpp:3278] Transitioning the state of container 6e5cddf0-5326-41dd-b978-af6d74c53a13
from RUNNING to DESTROYING
I0409 08:24:11.419919 39300 launcher.cpp:161] Asked to destroy container 6e5cddf0-5326-41dd-b978-af6d74c53a13
W0409 08:24:11.420856 33548 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=11732
to peer '192.10.1.4:64478': IO failed with error code: The specified network name is no longer
available.

W0409 08:24:11.420856 33548 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=11984
to peer '192.10.1.4:64477': IO failed with error code: The specified network name is no longer
available.

I0409 08:24:11.441877 3758[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (680
ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (697 ms total)

[----------] Global test environment tear-down
[==========] 1158 tests from 108 test cases ran. (588292 ms total)
[  PASSED  ] 1156 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

0 containerizer.cpp:3117] Container 6e5cddf0-5326-41dd-b978-af6d74c53a13 has exited
I0409 08:24:11.471849 42244 master.cpp:1135] Master terminating
I0409 08:24:11.473852 38152 hierarchical.cpp:680] Removed agent bec6eae5-5255-4922-908b-615934fac20f-S0
I0409 08:24:12.036937 33548 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 9, 2019, 8:01 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70430/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 8:01 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9452
>     https://issues.apache.org/jira/browse/MESOS-9452
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch keeps the sorting related information in the memory
> and accompanies a dirty bit with it. This helps to avoid
> unnecessary recalculation of this info in `sort()`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/random/sorter.hpp 125ce84761e4c930370912151700ddda35d7b6c1

>   src/master/allocator/sorter/random/sorter.cpp bbe130dbf3b158ea14f9572bc5d14200fcd85127

> 
> 
> Diff: https://reviews.apache.org/r/70430/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Benchmarking:
> Optimized build with QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> 
> tl;dr: Performance is now on par with before the change in r/70429
> 
> ## Before r/70429:
> Added 3000 agents in 85.844373ms
> Added 3000 frameworks in 19.713969615secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks
> Made 3500 allocations in 13.690538305secs
> Made 0 allocation in 9.76855825secs
> 
> ## After r/70429 and this:
> Added 3000 agents in 105.284907ms
> Added 3000 frameworks in 19.253697264secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks
> Made 3500 allocations in 13.488219803secs
> Made 0 allocation in 9.846584089secs
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message