mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70431: Made the `RetryRpcWithExponentialBackoff` SLRP test work with CSI v1.
Date Tue, 09 Apr 2019 06:09:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70431/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jan Schlicht.


Bugs: MESOS-9627
    https://issues.apache.org/jira/browse/MESOS-9627


Repository: mesos


Description
-------

This patch enables the unit test to test against CSI v1 through the
following changes:

  * The forwarding mode of the test CSI plugin now respects the
    `--api_version` option. When specified, only requests of the proper
    CSI version will be forwarded.

  * The expectations of `CreateVolume` and `DeleteVolume` calls in the
    unit tests are parameterized against the CSI version string.

  * The mock CSI plugin now provides a default implementation for the
    `GetCapacity` call so the unit test can be simplified.


Diffs
-----

  src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 
  src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
  src/tests/storage_local_resource_provider_tests.cpp da8db41b867d04b4236ad3515811fc00318c619c



Diff: https://reviews.apache.org/r/70431/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message