mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70404: Supported CSI v1 in the test CSI plugin.
Date Tue, 09 Apr 2019 06:06:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70404/
-----------------------------------------------------------

(Updated April 9, 2019, 6:06 a.m.)


Review request for mesos, Benjamin Bannier and Jan Schlicht.


Changes
-------

Addresed Benjamin's comments.


Bugs: MESOS-9627
    https://issues.apache.org/jira/browse/MESOS-9627


Repository: mesos


Description
-------

A new `--api_version` optional flag is added to the test CSI plugin. By
default, it will serve both CSI v0 and v1 requests. When this flag is
specified, only one CSI version will be served.


Diffs (updated)
-----

  include/mesos/csi/v0.hpp 8be070bcd241d6934f7473c4e56f1992535f76d2 
  include/mesos/csi/v1.hpp PRE-CREATION 
  src/examples/test_csi_plugin.cpp 4321f8f16cb12018f008002cdc5c9002a055e2b7 


Diff: https://reviews.apache.org/r/70404/diff/2/

Changes: https://reviews.apache.org/r/70404/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message