mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70400: Added capabilities and evolve/devolve helpers for CSI v1.
Date Tue, 09 Apr 2019 06:05:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70400/
-----------------------------------------------------------

(Updated April 9, 2019, 6:05 a.m.)


Review request for mesos, Benjamin Bannier and Jan Schlicht.


Changes
-------

Addressed Benjamin's comments in r/70399.


Bugs: MESOS-9623
    https://issues.apache.org/jira/browse/MESOS-9623


Repository: mesos


Description
-------

This patch adds capability helper structures for CSI v1 services, and
evolve/devolve helpers to convert between CSI v1 protobufs and their
unversioned counterparts.


Diffs (updated)
-----

  src/CMakeLists.txt af3715a060b677da86d6d9a56b360f17be2bd0d3 
  src/Makefile.am a80044448563b3507d08a81857097ba4a39210fe 
  src/csi/v1_utils.hpp PRE-CREATION 
  src/csi/v1_utils.cpp PRE-CREATION 
  src/tests/csi_utils_tests.cpp b9d0ca809734839db49b174ef8d253563a41e7fd 


Diff: https://reviews.apache.org/r/70400/diff/2/

Changes: https://reviews.apache.org/r/70400/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message