mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.
Date Tue, 09 Apr 2019 00:02:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70412/#review214481
-----------------------------------------------------------




src/examples/operation_feedback_framework.cpp
Lines 192 (patched)
<https://reviews.apache.org/r/70412/#comment300690>

    Let's use something more specific than this maybe? "operation_feedback_framework_label"
or something?
    
    Also, let's put this string in a constant since it is referenced elsewhere.



src/examples/operation_feedback_framework.cpp
Line 496 (original), 528 (patched)
<https://reviews.apache.org/r/70412/#comment300691>

    Should we remove this log line since we may receive operation status updates for unreservations
of resources from previous runs of the framework? Or maybe we could change it to INFO level?


- Greg Mann


On April 5, 2019, 11:35 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70412/
> -----------------------------------------------------------
> 
> (Updated April 5, 2019, 11:35 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a flag to the operation feedback example framework that
> makes it unreserve resources that were reserved by another instance of
> the framework.
> 
> NOTE: The new flag should only be enabled if the example framework is
> the only framework making reservations for a given role. Otherwise it
> will unreserve reservations made by another framework.
> 
> 
> Diffs
> -----
> 
>   src/examples/operation_feedback_framework.cpp 2480c340c4ccb4246098c35e0315093f3eb44e81

> 
> 
> Diff: https://reviews.apache.org/r/70412/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message